[BUGFIX release] Fix generated import paths for test setup functions in addons #20114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locks
approved these changes
Jun 11, 2022
kategengler
approved these changes
Jun 11, 2022
|
Thanks! Possible future improvement is to use your new utility fn here ember.js/blueprints/util-test/index.js Line 33 in f0b49d8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced a regression when implementing #19981.
The project's module prefix should be used instead of the addon's package name when generating these import paths, as these test setup functions are not located in the addon's
addonfolder, but in/tests/helpers/index.js.When approved, I will implement the same fix over in Ember Data.
Closes #20110.