Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX LTS] Allow class-based helpers in strict-mode #20286

Merged
merged 1 commit into from Nov 29, 2022

Conversation

gabrielcsapo
Copy link

@gabrielcsapo gabrielcsapo commented Nov 29, 2022

Summary

Backports the fix to #19877 (originally submitted in #19878) to work under 3.28.

Bug

Using class based helpers in strict mode results in the following in 3.28

TypeError: Cannot read properties of undefined (reading 'prototype')
                at ClassicHelperManager.getDebugName (http://localhost:7357/i18n-dummy/assets/vendor.js:7334:55)
                at http://localhost:7357/i18n-dummy/assets/vendor.js:40951:146
                at Object.evaluate (http://localhost:7357/i18n-dummy/assets/vendor.js:46402:17)
                at AppendOpcodes.evaluate (http://localhost:7357/i18n-dummy/assets/vendor.js:45783:19)
                at LowLevelVM.evaluateSyscall (http://localhost:7357/i18n-dummy/assets/vendor.js:48994:22)
                at LowLevelVM.evaluateInner (http://localhost:7357/i18n-dummy/assets/vendor.js:48965:14)
                at LowLevelVM.evaluateOuter (http://localhost:7357/i18n-dummy/assets/vendor.js:48958:14)
                at VM.next (http://localhost:7357/i18n-dummy/assets/vendor.js:49789:24)
                at VM._execute (http://localhost:7357/i18n-dummy/assets/vendor.js:49776:23)
                at VM.execute (http://localhost:7357/i18n-dummy/assets/vendor.js:49751:28)

@chadhietala
Copy link
Contributor

chadhietala commented Nov 29, 2022

FWIW I think this was supposed to be backported to the LTS (3.28 at the time) when it was fixed in #19878 as noted by @mixonic

@chriskrycho chriskrycho changed the title [Bugfix release] Allow class-based helpers in strict-mode [BUGFIX LTS] Allow class-based helpers in strict-mode Nov 29, 2022
@rwjblue rwjblue merged commit 14c02f5 into emberjs:lts-3-28 Nov 29, 2022
@rwjblue rwjblue added the Bug label Nov 29, 2022
@gabrielcsapo gabrielcsapo deleted the lts-3-28 branch November 29, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants