[BUGFIX LTS] Improve error for owner methods called after destroy #20385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous error handling gives you a stack trace and a notice, but does not tell you what was being asked for with the lookup. This makes the traces much less helpful, especially for minified/prod builds.
chriskrycho
force-pushed
the
better-post-destroy-error
branch
from
8b45f3f
to
3786a7e
Compare
rwjblue
approved these changes
Feb 22, 2023
|
I took this a step further in a patch lately and it got me thinking it would be nice to be able to hook this particular error and the "called set" error (basically the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous error handling gives you a stack trace and a notice, but does not tell you what was being asked for with the lookup. This makes the traces much less helpful, especially for minified/prod builds.