Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX LTS] Don't run getters while applying mixins #20388

Merged
merged 3 commits into from
Mar 8, 2023
Merged

[BUGFIX LTS] Don't run getters while applying mixins #20388

merged 3 commits into from
Mar 8, 2023

Commits on Mar 1, 2023

  1. [BUGFIX LTS] Don't run getters while applying mixins 

    This change ensures that getters are never evaluated while applying
mixins.

It relies on the fact that all getters (including undecorated ones) get
converted into classic decorators when the mixin is originally created.
    @wycats
    wycats committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    87394c4 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. Update packages/@ember/object/mixin.ts 

    Co-authored-by: Chris Krycho <hello@chriskrycho.com>
    @wycats @chriskrycho
    wycats and chriskrycho committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    4cd6394 View commit details
    Browse the repository at this point in the history

  2. Separate tsconfig change

    @wycats
    wycats committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    a037ae8 View commit details
    Browse the repository at this point in the history