[BUGFIX LTS 3.28] Don't run getters while applying mixins #20447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wycats
force-pushed
the
wycats/backport-20388
branch
3 times, most recently
from
0ae927c
to
6e80d88
Compare
wycats
changed the title
wycats
changed the title
wycats
force-pushed
the
wycats/backport-20388
branch
5 times, most recently
from
1bfa809
to
4d8fd8c
Compare
|
@kategengler I backported a bunch of the CI changes to get the tests passing but I'm not sure if I did it correctly. Can you give them a quick once over? |
kategengler
reviewed
Apr 28, 2023
package.json
Outdated
| @@ -150,7 +150,7 @@ | |||
| "tslint": "^5.20.1" | |||
| }, | |||
| "engines": { | |||
| "node": "10.* || >= 12.*" | |||
| "node": ">= 14.*" | |||
There was a problem hiding this comment.
We definitely cannot update engines in 3.28 point release
|
@wycats What about CI was failing? We typically cherry-pick just commits back to the older versions and CI usually keeps working. |
|
@kategengler I'll take another look at it. I think it might be tricky to avoid upgrades without somehow pinning other infrastructure like Embroider stuff, which we also might not want to do. |
This change ensures that getters are never evaluated while applying mixins. It relies on the fact that all getters (including undecorated ones) get converted into classic decorators when the mixin is originally created.
wycats
force-pushed
the
wycats/backport-20388
branch
from
4d8fd8c
to
41da13e
Compare
kategengler
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #20388
This change ensures that getters are never evaluated while applying
mixins.
It relies on the fact that all getters (including undecorated ones) get
converted into classic decorators when the mixin is originally created.