Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX LTS] An addon re-export should always be a JavaScript file #20595

Merged
merged 1 commit into from Dec 12, 2023

Conversation

bertdeblock
Copy link
Member

We should never generate .ts files in an addon's app folder.

@kategengler
Copy link
Member

Thank you, should this be backported?

@bertdeblock
Copy link
Member Author

I think so yes. AFAICT, this has been an issue even before v4.8 LTS.

@kategengler kategengler changed the title [BUGFIX] An addon re-export should always be a JavaScript file [BUGFIX LTS] An addon re-export should always be a JavaScript file Dec 12, 2023
@kategengler kategengler merged commit 4869052 into emberjs:main Dec 12, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants