Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated function-style rules to object-style (and add/update internal linters) #27

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

bmish
Copy link
Collaborator

@bmish bmish commented Dec 11, 2021

Both of these are recommended for eslint plugins:

  • eslint-plugin-eslint-plugin is a popular plugin for enforcing best practices for eslint plugins
    • I converted some old-style function rules to object rules to comply with this, this will be needed for ESLint v9 compatibility
  • eslint-plugin-node

Also updated other linting dependencies while I was here.

@@ -1,7 +1,12 @@
'use strict';

/** @type {import('eslint').Rule.RuleModule} */
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explanation of this jsdoc comment: ember-cli/eslint-plugin-ember#1301

@bmish
Copy link
Collaborator Author

bmish commented Jan 18, 2022

@rwjblue or anyone who maintains this repository, can you give me github write access and NPM publishing permission (npm user: bmishkin)? Then I can help maintain this more easily. I maintain eslint-plugin-ember, eslint core, and many other eslint plugins.

@bmish bmish force-pushed the eslint-plugin-eslint-plugin branch from a5dd0f4 to f86af03 Compare December 5, 2022 17:47
@bmish bmish added the internal label Dec 5, 2022
@bmish bmish force-pushed the eslint-plugin-eslint-plugin branch 5 times, most recently from dda2a10 to cf170dc Compare December 5, 2022 18:55
@bmish bmish force-pushed the eslint-plugin-eslint-plugin branch from cf170dc to 000d41d Compare December 5, 2022 18:56
@bmish bmish merged commit b38ce38 into emberjs:master Dec 5, 2022
@bmish bmish deleted the eslint-plugin-eslint-plugin branch December 5, 2022 18:57
@bmish bmish changed the title Add eslint-plugin-eslint-plugin and eslint-plugin-node Update deprecated function-style rules to object-style (and add/update internal linters) Dec 5, 2022
@bmish bmish added bug and removed internal labels Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant