upgrade webpack #299
Merged
upgrade webpack #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have been pinned to an older webpack for a while due to webpack/webpack#8656, which is really an NPM bug that gets tickled by the particular set of deps that come into play with webpack 4.29. But we can't stay pinned forever. The [npm bug](https://npm.community/t/packages-with-peerdependencies-are-incorrectly-hoisted/4794/13) is effectively wontfix because NPM gets peerDeps wrong at a really deep level. Hopefully enough other deps have shifted by now that the bug doesn't manifest often.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been pinned to an older webpack for a while due to webpack/webpack#8656, which is really an NPM bug that gets tickled by the particular set of deps that come into play with webpack 4.29.
But we can't stay pinned forever. The npm bug is effectively wontfix because NPM gets peerDeps wrong at a really deep level.
Hopefully enough other deps have shifted by now that the bug doesn't manifest often.