Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widen the node_modules exclude pattern when copying v2 addons #1068

Merged
merged 1 commit into from Jan 8, 2022
Merged

Widen the node_modules exclude pattern when copying v2 addons #1068

merged 1 commit into from Jan 8, 2022

Commits on Jan 8, 2022

  1. exclude inner node modules 

    When we encounter a v2 addon that has v1 addon as dependencies, we need to move it even tough it doesn't need to be rewritten. Our code for doing that excludes node_modules, but we should also exclude inner nested node_modules.

This comes up when testing a v2 addon that nests its test-app inside itself using symlinked node_modules. Without this you encounter a symlink cycle that's hard to diagnose and only strikes on some OS / disk combinations.
    @ef4
    ef4 committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    0d47db4 View commit details
    Browse the repository at this point in the history