Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize addonCacheKey computation #1102

Merged
merged 1 commit into from Feb 5, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 22 additions & 4 deletions packages/macros/src/macros-config.ts
Expand Up @@ -39,16 +39,34 @@ type GlobalSharedState = WeakMap<
// share the GlobalSharedState beneath.
let localSharedState: WeakMap<any, MacrosConfig> = new WeakMap();

function gatherAddonCacheKeyWorker(item: any, memo: Set<string>) {
item.addons.forEach((addon: any) => {
let key = `${addon.pkg.name}@${addon.pkg.version}`;
memo.add(key);
gatherAddonCacheKeyWorker(addon, memo);
});
}

let addonCacheKey: WeakMap<any, string> = new WeakMap();
// creates a string representing all addons and their versions
// (foo@1.0.0|bar@2.0.0) to use as a cachekey
function gatherAddonCacheKey(item: any, memo = new Set()) {
item.addons.forEach((addon: any) => {
function gatherAddonCacheKey(project: any): string {
let cacheKey = addonCacheKey.get(project);
if (cacheKey) {
return cacheKey;
}

let memo: Set<string> = new Set();
project.addons.forEach((addon: any) => {
let key = `${addon.pkg.name}@${addon.pkg.version}`;
memo.add(key);
gatherAddonCacheKey(addon, memo);
gatherAddonCacheKeyWorker(addon, memo);
});

return [...memo].join('|');
cacheKey = [...memo].join('|');
addonCacheKey.set(project, cacheKey);

return cacheKey;
}

export default class MacrosConfig {
Expand Down