Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a workaround that is trying fix an old bug in volta #1144

Merged
merged 1 commit into from Feb 26, 2022

Conversation

krisselden
Copy link
Contributor

This forces scenario tester onto a new version that link bins so that when we remove the workaround and volta runs yarn in the correct context, it finds ./node_modules/.bin/ember in the test scenario itself.

This forces scenario tester onto a new version that link bins
so that when we remove the workaround and volta runs yarn in the
correct context, it finds ./node_modules/.bin/ember in the
test scenario itself.
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3 deleted code 🎉

@ef4 ef4 merged commit e9bbbad into embroider-build:main Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants