Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MiniCssExtractPlugin for FastBoot builds #1146

Merged
merged 4 commits into from Mar 3, 2022
Merged

Use MiniCssExtractPlugin for FastBoot builds #1146

merged 4 commits into from Mar 3, 2022

Conversation

simonihmig
Copy link
Collaborator

First: In apps with fastboot, @embroider/webpack should automatically use MiniCssExtractPlugin even in development (as opposed to style-loader, which is fine in development for apps that don't have fastboot). ember-auto-import already has this policy and embroider should do the same. This would be a great well-scoped PR.

#1049 (comment)

@simonihmig simonihmig added the enhancement New feature or request label Feb 28, 2022
@ef4 ef4 mentioned this pull request Feb 28, 2022
Closed
@ef4
Copy link
Contributor

ef4 commented Mar 3, 2022

Thanks!

@ef4 ef4 merged commit be9de27 into embroider-build:main Mar 3, 2022
@simonihmig
Copy link
Collaborator Author

Thanks for tweaking the PR with this commit, reverting my choice to add an additional hasFastBoot flag to Variant. I was initially hesitant to add this, but I thought we would need to disambiguate a browser build with and without FastBoot. But you are right, given how the combinations of runtime and optimizeForProduction are created, that flag was actually redundant. Good catch then, I should have looked into it more deeply!

@simonihmig simonihmig deleted the mini-css-extract-for-fastboot branch March 3, 2022 08:45
@ef4
Copy link
Contributor

ef4 commented Mar 3, 2022

Well none of this is well documented of you to discover the original intent, so it's very understandable!

But yes, my intention for "runtime" is that it should cover this case.

backspace added a commit to cardstack/cardstack that referenced this pull request Mar 4, 2022
@backspace
ssr: Update Embroider to 1.3.0
945c8fa 
The CSS bug that made development builds not work has been
fixed, thanks to @simonihmig!

embroider-build/embroider#1146
@backspace backspace mentioned this pull request Mar 4, 2022
Merged
backspace added a commit to cardstack/cardstack that referenced this pull request Mar 7, 2022
@backspace
ssr: Update Embroider to 1.3.0 (#2761)
73d31ba 
The CSS bug that made development builds not work has been
fixed, thanks to @simonihmig!

embroider-build/embroider#1146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simonihmig @ef4