improve test suite compat #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no reason not to provide every module under /tests to the runtime loader. This is closer to how classic builds work and doesn't have a downside. In an earlier version, we used to need to identify which files were actually tests because we would eagerly evaluate them all (and skip the traditional ember test loader), but that was already scrapped in favor of easier compatibility for test suites, so I don't think this has a downside. The motivating use case for this was ember-data-factory-guy, which does runtime lookup of modules in `tests/factories` that don't match the `-test.js` naming convention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no reason not to provide every module under /tests to the runtime loader. This is closer to how classic builds work and doesn't have a downside.
In an earlier version, we used to need to identify which files were actually tests because we would eagerly evaluate them all (and skip the traditional ember test loader), but that was already scrapped in favor of easier compatibility for test suites, so I don't think this has a downside.
The motivating use case for this was ember-data-factory-guy, which does runtime lookup of modules in
tests/factoriesthat don't match the-test.jsnaming convention.