Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn ensureSafeComponent into a no-op for class values on Ember 3.25+ #1155

Merged
merged 1 commit into from Mar 8, 2022
Merged

Turn ensureSafeComponent into a no-op for class values on Ember 3.25+ #1155

merged 1 commit into from Mar 8, 2022

Conversation

Windvis
Copy link
Collaborator

@Windvis Windvis commented Mar 7, 2022

Closes #1061

@rwjblue rwjblue added the enhancement New feature or request label Mar 7, 2022
@ef4
Copy link
Contributor

ef4 commented Mar 8, 2022

Very nice!

@ef4 ef4 merged commit f15f5f5 into embroider-build:main Mar 8, 2022
@Windvis Windvis deleted the chore/ensure-safe-component-class-no-op branch March 18, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ensureSafeComponent can be a no-op for classes on newer embers
3 participants
@Windvis @ef4 @rwjblue