Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure self-references within a dummy apps work for @ resolution. #1170

Merged
merged 2 commits into from Apr 7, 2022

Conversation

rwjblue
Copy link
Collaborator

@rwjblue rwjblue commented Mar 28, 2022

Fixes #1072

@angelayanpan
Copy link
Collaborator

@rwjblue can you please take a look at the failing checks?

@rwjblue
Copy link
Collaborator Author

rwjblue commented Mar 30, 2022

can you please take a look at the failing checks?

The CI failures are also failing on master, we need to figure them out and fix them in a separate PR to unblock this and other pending work...

@angelayanpan
Copy link
Collaborator

I think @ef4 's fix went in. Can you trigger a rerun for this @rwjblue?

@rwjblue rwjblue force-pushed the updates-for-local-imports-batman-syntax branch from 56dd102 to 1a09641 Compare April 7, 2022 18:32
@rwjblue
Copy link
Collaborator Author

rwjblue commented Apr 7, 2022

Rebased to pull in #1186 to fixup CI

@rwjblue rwjblue added the bug Something isn't working label Apr 7, 2022
@ef4 ef4 merged commit 5976a37 into main Apr 7, 2022
@ef4 ef4 deleted the updates-for-local-imports-batman-syntax branch April 7, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to resolve package {addon-name} when using HFTNB syntax to reference components in the same addon
3 participants