Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write files plugin #1177

Merged
merged 2 commits into from Apr 21, 2022
Merged

Conversation

krisselden
Copy link
Contributor

@krisselden krisselden commented Apr 4, 2022

this moves the post build stuff into webpack, this is also a step toward running webpack out of process (this stuff can be separated more but this PR is trying to make the diff smaller).

Since this moves one post process into 2 compilers, this adds some microtask concurrency, this makes sure the has() guards synchronously set() after has() fails and it makes both sides get to the html entrypoint check, then only has the variant 0 emit the html entrypoint.

@krisselden krisselden force-pushed the write-files-plugin branch 2 times, most recently from 1f65dcc to e56ca3f Compare April 4, 2022 21:19
@krisselden
Copy link
Contributor Author

Seems to be something wrong with the fastboot variant stuff.

@SergeAstapov SergeAstapov added the bug Something isn't working label Apr 15, 2022
@rwjblue rwjblue merged commit 93148c4 into embroider-build:main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants