Fix thread-load JOBS handling/documentation #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
04d39ba missed one JOBS check, and left it checking for `1` instead of `0`, and also didn't update the documentation/comment. Fortunately, it was relatively harmless (related to warming the thread-loader pool, which is just a performance thing) So I consolidated the code into a helper function to ensure consistency, and updated the comment.
rwjblue
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
04d39ba missed one JOBS check, and left it checking for
1instead of0, and also didn't update the documentation/comment. Fortunately, it was relatively harmless (related to warming the thread-loader pool, which is just a performance thing) So I consolidated the code into a helper function to ensure consistency, and updated the comment.