fastboot should not try to load through publicAssetURL #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an application has customized the publicAssetURL, it means browsers should load assets from that URL prefix. However, *fastboot* doesn't work that way and always loads assets from a local `dist` directory. So when publicAssetURL differs from rootURL, we need to emit different URLs for fastboot vs browser. Thankfully, the fastboot protocol V5 (which embroider already relies on) was designed to account for fastboot-specific assets via both `<fastboot-script src="...">` and `<script data-fastboot-src="...">`, so we can easily emit output that provides consistent views to both browses and fastboot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an application has customized the publicAssetURL, it means browsers should load assets from that URL prefix. However, fastboot doesn't work that way and always loads assets from a local
distdirectory. So when publicAssetURL differs from rootURL, we need to emit different URLs for fastboot vs browser.Thankfully, the fastboot protocol V5 (which embroider already relies on) was designed to account for fastboot-specific assets via both
<fastboot-script src="...">and<script data-fastboot-src="...">, so we can easily emit output that provides consistent views to both browses and fastboot.