New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ember engines #1915

Open

mansona wants to merge 2 commits into main from update-engines

Member

mansona commented May 14, 2024

No description provided.


          update ember engines

afecd84

SergeAstapov previously approved these changes

View reviewed changes


          unskip engines tests

b9e9a3b

mansona mentioned this pull request

unskip engines tests #1916

Draft

mansona dismissed SergeAstapov’s stale review

May 15, 2024 11:12

Dismissing until we get tests passing

Member Author

mansona commented May 15, 2024

@SergeAstapov turns out we weren't testing engines at all on main 🫠 so we should probably make sure tests are passing before we update the dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment