Add "sideEffects": false to all internal package.json files in `@…

…emotion/react` (#2112)
emotion-js · Nov 17, 2020 · fdd46bd · fdd46bd
1 parent 781173f
commit fdd46bd
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 0 deletions.
diff --git a/.changeset/fifty-actors-collect.md b/.changeset/fifty-actors-collect.md
@@ -0,0 +1,5 @@
+---
+'@emotion/react': patch
+---
+
+Fixed the latest tree-shakeability improvements by adding `"sideEffects": false` to all internal `package.json` files as well. This fixes [`hoist-non-react-statics`](https://github.com/mridgway/hoist-non-react-statics) not being dropped correctly despite of the latest improvements.
diff --git a/packages/react/isolated-hoist-non-react-statics-do-not-use-this-in-your-code/package.json b/packages/react/isolated-hoist-non-react-statics-do-not-use-this-in-your-code/package.json
@@ -6,6 +6,7 @@
     "./dist/emotion-react-isolated-hoist-non-react-statics-do-not-use-this-in-your-code.cjs.js": "./dist/emotion-react-isolated-hoist-non-react-statics-do-not-use-this-in-your-code.browser.cjs.js",
     "./dist/emotion-react-isolated-hoist-non-react-statics-do-not-use-this-in-your-code.esm.js": "./dist/emotion-react-isolated-hoist-non-react-statics-do-not-use-this-in-your-code.browser.esm.js"
   },
+  "sideEffects": false,
   "preconstruct": {
     "umdName": "emotionHoistNonReactStatics"
   }

diff --git a/packages/react/jsx-dev-runtime/package.json b/packages/react/jsx-dev-runtime/package.json
@@ -7,6 +7,7 @@
     "./dist/emotion-react-jsx-dev-runtime.esm.js": "./dist/emotion-react-jsx-dev-runtime.browser.esm.js"
   },
   "types": "../types/jsx-dev-runtime",
+  "sideEffects": false,
   "preconstruct": {
     "umdName": "emotionReactJSXDevRuntime"
   }

diff --git a/packages/react/jsx-runtime/package.json b/packages/react/jsx-runtime/package.json
@@ -7,6 +7,7 @@
     "./dist/emotion-react-jsx-runtime.esm.js": "./dist/emotion-react-jsx-runtime.browser.esm.js"
   },
   "types": "../types/jsx-runtime",
+  "sideEffects": false,
   "preconstruct": {
     "umdName": "emotionReactJSXRuntime"
   }