feat(serialize): Bump csstype #1956
Conversation
🦋 Changeset is good to goLatest commit: e9c87f0 We got this. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/serialize/types/tests.ts
Outdated
| @@ -16,41 +16,41 @@ const testObjectInterpolation1: ObjectInterpolation<undefined> = { | |||
| } | |||
|
|
|||
| // $ExpectType SerializedStyles | |||
| serializeStyles({}, []) | |||
| serializeStyles([], {}) | |||
There was a problem hiding this comment.
any particular reason why those tests had to be updated?
There was a problem hiding this comment.
They did not pass on master
There was a problem hiding this comment.
More specifically: Most of the packages do not pass their own test:typescript on master and types aren't tested in CI. I don't know about the state of next but it's not apparent from CONTRIBUTING.md on which branch development should happen.
|
Do you know what kind of breaking changes were included in v3? It's not super apparent from this: https://www.npmjs.com/package/csstype#version-30 |
This seems sufficient to me. With types breaking changes reveal themselves. Anything that's not necessarily findable with a structural type system is listed e.g. |
Our consumers might often not be aware that they are using an external library like
Isn't it a new feature, sort-of, rather than a breaking change? As is - it seems to allow more than before? |
Can't fault by making a bigger bump than necessary.
Quickly scanned the project and could not see any exposure of these namespaces. I could not find any breakage in dependent packages when csstype was bumped in the |
|
Ok - thanks for checking this. I will handle this soon-ish - need to recheck versioning between master&next and other organizational stuff in the repo. I assume you are interested in including this change in the current latest version (v10) and waiting for it to be released in the upcoming major version (v11) is not good enough, right? |
It's not blocking me in any way. Whatever timeline works best for you should be preferred. |
# Conflicts: # packages/serialize/package.json # packages/serialize/types/tests.ts # packages/serialize/types/tslint.json # yarn.lock
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e9c87f0:
|
* Remove grayscale filter from the docs (emotion-js#1929) * Add emotion-native-extended to the ecosystem list of packages (emotion-js#1849) * Make links more accessible in the docs (emotion-js#1930) * run test:typescript for emotion/serialize in CI * fix emotion/serialize type tests * Bump csstype to 3.0.2 * Add changeset * Update .circleci/config.yml * Tweak changeset Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com> Co-authored-by: Wendell Misiedjan <wmisiedj@student.codam.nl>
What:
Bump
csstypein@emotion/serialize.Why:
Align type ecosystem to avoid potential type conflicts. All
@types/*packages already switched DefinitelyTyped/DefinitelyTyped#46435How:
test:typescriptis ran in CItest:typescriptfirstcsstypeand see iftest:typescriptstill passes (it does)Checklist:
[ ] Documentation