Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved tree-shakeability of the @emotion/react package #2101

Merged
merged 2 commits into from
Nov 16, 2020

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Nov 13, 2020

fixes #2100

@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2020

🦋 Changeset detected

Latest commit: ce0fa43

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@emotion/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 13, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ce0fa43:

Sandbox Source
Emotion Configuration


// have to wrap it in a proxy function because Rollup is too damn smart
// and if this module doesn't actually contain any logic of its own
// then Rollup just use 'hoist-non-react-statics' directly in other chunks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

@Andarist Andarist merged commit 0e465d1 into master Nov 16, 2020
@Andarist Andarist deleted the emotion-react/improved-tree-shaking branch November 16, 2020 06:08
@github-actions github-actions bot mentioned this pull request Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack is unable to tree-shake unused theming code
2 participants