Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make Flow infer prop types for inline styled functions #2199

Merged
merged 4 commits into from
Mar 12, 2021

Conversation

FezVrasta
Copy link
Member

What:

Current Flow types don't automatically infer the props types for inline functions passed to the styled() calls.

Why:

Improved the Flow type defs.

How:

Checklist:

  • Documentation N/A
  • Tests
  • Code complete
  • Changeset

@changeset-bot
Copy link

changeset-bot bot commented Jan 2, 2021

🦋 Changeset detected

Latest commit: f10e1ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@emotion/styled Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 2, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f10e1ae:

Sandbox Source
Emotion Configuration

@gabrielmicko
Copy link

@FezVrasta Thanks for fixing my issue.

@Andarist Andarist merged commit 734b36b into emotion-js:master Mar 12, 2021
@FezVrasta FezVrasta deleted the fix/flow-types-inline-fn-props branch March 12, 2021 12:46
@github-actions github-actions bot mentioned this pull request Mar 12, 2021
@github-actions github-actions bot mentioned this pull request Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants