Remove as prop for composed components (fixes #2238)
#2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts composed with `styled`
🦋 Changeset detectedLatest commit: 5deb8d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5deb8d3:
|
|
Thank you for the PR! I'll try to review this sometime this week but for the last 2 weeks I had much less free time for OSS than usual and issues to handle have piled on me so please be patient. |
Merged
This was referenced Mar 15, 2021
facebook-github-bot
pushed a commit
to facebook/flipper
that referenced
this pull request
Mar 23, 2021
Summary: Bumps [emotion/styled](https://github.com/emotion-js/emotion) from 11.0.0 to 11.1.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/emotion-js/emotion/releases"><code>@emotion/styled's releases</code></a>.</em></p> <blockquote> <h2>emotion/styled@11.1.5</h2> <h3>Patch Changes</h3> <ul> <li> <p><a href="https://github.com/emotion-js/emotion/commit/d0293508016dc07c5ad502b9eb0bec99ede1d37b"><code>d0293508</code></a> <a href="https://github.com/emotion-js/emotion/pull/2240">#2240</a> Thanks <a href="https://github.com/wolszczak96"><code>@wolszczak96</code></a>! - <code>as</code> prop has been removed from TypeScript declarations for composite components. This prop has not actually been handled by default by <code>styled</code> for those components - to make <code>styled</code> handle it you need to provide a custom <code>shouldForwardProp</code> that doesn't forward the <code>as</code> prop.</p> </li> <li> <p>Updated dependencies [<a href="https://github.com/emotion-js/emotion/commit/f3c2e81d10b63811ebbc6c5b11fa3553a2605f44"><code>f3c2e81d</code></a>]:</p> <ul> <li>emotion/is-prop-valid@1.1.0</li> </ul> </li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/emotion-js/emotion/commit/2fe9e0e945be8a933521a96c2a242c5b397aa846"><code>2fe9e0e</code></a> Version Packages (<a href="https://github.com/emotion-js/emotion/issues/2207">#2207</a>)</li> <li><a href="https://github.com/emotion-js/emotion/commit/d0293508016dc07c5ad502b9eb0bec99ede1d37b"><code>d029350</code></a> Removed type for <code>as</code> prop for composite components (<a href="https://github.com/emotion-js/emotion/issues/2240">#2240</a>)</li> <li><a href="https://github.com/emotion-js/emotion/commit/f3c2e81d10b63811ebbc6c5b11fa3553a2605f44"><code>f3c2e81</code></a> Added <code>option</code> & <code>fallback</code> AMP props to the list of valid props (<a href="https://github.com/emotion-js/emotion/issues/2232">#2232</a>)</li> <li><a href="https://github.com/emotion-js/emotion/commit/b62647e8f52c9646d7f4f6eb789db1b84c94228a"><code>b62647e</code></a> Fix regex to comply with no-useless-escape ESLint rule</li> <li><a href="https://github.com/emotion-js/emotion/commit/400c6f72905a4676f852b09405421a7ca8d7a3a2"><code>400c6f7</code></a> Update slack link</li> <li><a href="https://github.com/emotion-js/emotion/commit/00cb6141a74f374efb8a01218e4518ce691f1723"><code>00cb614</code></a> Update example describing how one can provide a library theme type using inte...</li> <li><a href="https://github.com/emotion-js/emotion/commit/4d2e732e9f0c8385c77c7bc43d4ccea7b30b9d37"><code>4d2e732</code></a> Added export for <code>SerializedStyles</code> Flow type from <code>emotion/react</code> (<a href="https://github.com/emotion-js/emotion/issues/2206">#2206</a>)</li> <li><a href="https://github.com/emotion-js/emotion/commit/a89d4257b0246a1640a99f77838e5edad4ec4386"><code>a89d425</code></a> Lift Emotion 11 codemod instructions to the earlier spot in the docs (<a href="https://github.com/emotion-js/emotion/issues/2194">#2194</a>)</li> <li><a href="https://github.com/emotion-js/emotion/commit/a1e44aa56b1c54ec20aa9e49cfa76fa74583ba81"><code>a1e44aa</code></a> Version Packages (<a href="https://github.com/emotion-js/emotion/issues/2187">#2187</a>)</li> <li><a href="https://github.com/emotion-js/emotion/commit/71ca9be3368ddb0a95ef5b2db7a97c67ab440593"><code>71ca9be</code></a> Fix TypeScript support for custom components with non-standard declarations (...</li> <li>Additional commits viewable in <a href="https://github.com/emotion-js/emotion/compare/emotion/styled@11.0.0...@emotion/styled@11.1.5">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Pull Request resolved: #2067 Reviewed By: passy Differential Revision: D27230129 Pulled By: priteshrnandgaonkar fbshipit-source-id: fcd95fb0db6b160df165189b6841ce5a42694459
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
fix #2238
Why:
discussed in the issue
How:
Just removed the
asprop from packages/styled/types/base.d.ts + added some testsChecklist: