Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support typings for Jest v29 #2884

Merged
merged 2 commits into from Sep 7, 2022
Merged

Conversation

billyjanitsch
Copy link
Contributor

What:

Similar to #2456 and #2771. Allows @emotion/jest to be compatible with the typings for Jest v29.

Why:

See https://jestjs.io/blog/2022/08/25/jest-29. No relevant breaking changes, so it should be fine to permit the additional typing peer dep.

How:

Expanded the peer dep range.

Checklist:

  • Documentation N/A
  • Tests N/A
  • Code complete
  • Changeset

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2022

🦋 Changeset detected

Latest commit: 7d1630d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@emotion/jest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 7, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7d1630d:

Sandbox Source
Emotion Configuration

@srmagura
Copy link
Member

srmagura commented Sep 7, 2022

Thanks! I tested our types against @types/jest 29.0.0 and it worked.

@srmagura srmagura enabled auto-merge (squash) September 7, 2022 19:30
@srmagura srmagura merged commit da1e68e into emotion-js:main Sep 7, 2022
@github-actions github-actions bot mentioned this pull request Sep 7, 2022
@billyjanitsch billyjanitsch deleted the jest-29 branch September 7, 2022 20:20
@billyjanitsch
Copy link
Contributor Author

Thanks for the quick turnaround, @srmagura! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants