Remove peer dependency on @babel/core from most packages

[emmatown]

Closes #2921
Closes #2660

So the only reason there is a peer dependency on @babel/core is because of @babel/plugin-syntax-jsx. I don't really think doing we even need to make @emotion/babel-plugin inherit @babel/plugin-syntax-jsx tbh since the only case it would matter is if people were running @emotion/babel-plugin without a JSX transform but just to not change the behaviour, I've inlined @babel/plugin-syntax-jsx. I think the cost of inlining it is more than worth it for getting rid of a peer dependency warning for most users.

[changeset-bot]

🦋 Changeset detected

Latest commit: 42451cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@emotion/babel-plugin	Patch
@emotion/css	Patch
@emotion/native	Patch
@emotion/primitives	Patch
@emotion/react	Patch
@emotion/styled	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 42451cd:

Sandbox	Source
Emotion	Configuration

[codecov]

Codecov Report

Merging #2985 (4f84220) into main (88ce707) will decrease coverage by 0.03%.
The diff coverage is 87.50%.

❗ Current head 4f84220 differs from pull request most recent head 42451cd. Consider uploading reports for the commit 42451cd to get more accurate results

Impacted Files	Coverage Δ
packages/babel-plugin/src/index.js	94.01% <87.50%> (-0.48%)	⬇️

[Andarist]

this depends on @babel/types but I guess that it should be mostly OK since those are just factories for simple objects and they shouldn't rely on identity of any class or anything like that

[Andarist]

This feels off but I guess that it's not a big deal if we omit it from here - we mostly use Babel through what we are given by the caller anyway.

[Andarist]

i'm also still curious though - is this removal technically needed to fix the mentioned issues? Isn't inling@babel/plugin-syntax-jsx already sufficient?

[Andarist]

This comment indirectly answers this question. This is somewhat needed today because we have a direct dependency on @emotion/babel-plugin in some packages.

[Andarist]

What do you think about moving macros completely out of the main packages in Emotion 12 (not that I currently plan to release a new version)?

[emmatown]

Maybe? Could just make the babel plugin an optional peer dependency though? (Note currently @babel/core isn't an optional peer dependency regardless of those peerDependenciesMeta since it's a non-optional peerDependency of @babel/plugin-syntax-jsx)

[Andarist]

Note currently @babel/core isn't an optional peer dependency regardless of those peerDependenciesMeta since it's a non-optional peerDependency of @babel/plugin-syntax-jsx)

Hm, isn't this a problem with the package manager? If we optionally depend in A on B that depends non-optionally on C that shouldn't transitively make C a required dependency of A 🤔

[emmatown]

We non-optionally depend on B (@babel/plugin-syntax-jsx) in this case

[Andarist]

I don't get it... @emotion/react has an optional peer dependency on @emotion/babel-plugin and that has a non-optional dependency on @babel/plugin-syntax-jsx. I don't understand how that non-optional dependency should be relevant for @emotion/react when it's only "pulled in" through an optional peer dep.

[emmatown]

@emotion/react has a normal (non-peer) dependency on @emotion/babel-plugin

[Andarist]

@emotion/react has a normal (non-peer) dependency on @emotion/babel-plugin

Ah, I see... I was focusing on the @babel/core itself.

[michaelgmiller1]

Amazing this was fixed!! This will get rid of our last peerDependency warning. Hoping for a version cut soon 🤞