Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #3086

Closed
wants to merge 1 commit into from
Closed

Update package.json #3086

wants to merge 1 commit into from

Conversation

Shay-repos
Copy link

It should depend on version >=16.8.0
keeping 16.14.0 will break storybook and other library which depends on this hook

What: Changing react dependency

Why: Some storybook addons depend on this hook, which depends directly on a specific version of React (16.14.0). Because of this direct dependency, package managers will import multiple versions of react

How: Relax React's version

Checklist:

  • Documentation
  • Tests
  • Code complete
  • Changeset

It should depend on version >=16.8.0
keeping 16.14.0 will break storybook and other library which depends on this hook
@changeset-bot
Copy link

changeset-bot bot commented Jul 28, 2023

⚠️ No Changeset found

Latest commit: 98f3f07

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@emmatown
Copy link
Member

This is a dev dependency so it doesn't affect anything outside this repo

@emmatown emmatown closed this Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants