Emotion 10 docs #799
Merged
Emotion 10 docs #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Worth reading through - facebook/react#13456 . I suspect those problems don't apply as much to us as in react-redux, but still would be good to benchmark this for emotion@10 |
Codecov Report
|
Andarist
reviewed
Oct 1, 2018
| ``` | ||
|
|
||
| Alternatively, you can use the css prop and create a regular component like this. | ||
| Some css-in-js libraries offer APIs to attach props to components, instead of having our own API to do that, we recommend creating a regular react component, using the css prop and attaching props like you would with any other React component. |
There was a problem hiding this comment.
while this obviously should not require an example, maybe it's worth to add one, just so we can refer people to it when they start asking
There was a problem hiding this comment.
The example for it is below.
Andarist
reviewed
Oct 1, 2018
| @@ -154,3 +154,22 @@ render(<H1 color="lightgreen">This is lightgreen.</H1>) | |||
| ``` | |||
|
|
|||
| This API was inspired by [glamorous](https://github.com/paypal/glamorous). ❤️ | |||
|
|
|||
| ### Customizing prop forwarding | |||
|
🎉🎉🎉❤️❤️❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very WIP and I'm aware a bunch of stuff is broken and I haven't totally figured out how we're going to fit the docs for the old api with the new docs but I wanted to open this anyway
https://next-docs.emotion.sh