feat: update rollup to version 4.9.1 #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check PR 399 preview 👀 |
|
Check PR 399 preview 👀 |
|
Check PR 399 preview 👀 |
|
Check PR 399 preview 👀 |
|
Check PR 399 preview 👀 |
|
Check PR 399 preview 👀 |
diegopf
changed the title
diegopf
changed the title
|
Check PR 399 preview 👀 |
lauramargar
previously approved these changes
Dec 28, 2023
|
Check PR 399 preview 👀 |
annacv
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to update some key dependencies:
@empathyco/x-componentsand other empathy packagesBesides, it also fixes a bug regarding the chunks. Currently the search chunk is almost empty and is not being lazy loaded. On the PR preview you can check that now the search chunk is back to have a significant content and is not loaded until the user starts searching for a query.
NOTE:
When doing the rollup build you might see a circular dependency, that is a problem on the
@vueuse/corelibrary that has been fixed on this PR and it will be gone when we update the version on x-componentsEMP-3186