Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump lerna to v7 #1299

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

bump lerna to v7 #1299

wants to merge 2 commits into from

Conversation

diegopf
Copy link
Contributor

@diegopf diegopf commented Sep 25, 2023

This PR updates Lerna to version 7. The decision to update Lerna was made because Prettier v3 requires it, and this transition has been seamless for us.

The changes introduced in this PR go beyond just bumping the version numbers. They also include updates made necessary by running lerna repair, as recommended in the Lerna v7 changelog.

@@ -21,5 +21,11 @@
"test": {
"outputs": ["{projectRoot}/coverage"]
}
},
"$schema": "./node_modules/nx/schemas/nx-schema.json",
"namedInputs": {
Copy link
Contributor Author

@diegopf diegopf Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This configuration is related to how the nx cache works and when it should be invalidated, see nx docs. Given that we had issues with the cache in the past, we should take a look at this in the future.

@diegopf diegopf marked this pull request as ready for review September 25, 2023 14:24
@diegopf diegopf requested a review from a team as a code owner September 25, 2023 14:24
Copy link
Contributor

@annacv annacv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gj!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants