Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace DisableAnimationMixin by useDisableAnimation composable #1469

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

alvarodE
Copy link
Contributor

Motivation and context

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@alvarodE alvarodE self-assigned this May 14, 2024
@@ -19,8 +19,7 @@ if (VUE_COMPAT_MODE === 2) {
*/
INSTANCE_LISTENERS: 'suppress-warning',
RENDER_FUNCTION: false,
COMPONENT_V_MODEL: false,
WATCH_ARRAY: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This warning is OK, we could and should fix it as part of the first phase of the migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant