Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Migrate x Modules Search Box to Composition API #1476

Merged
merged 23 commits into from
May 23, 2024
Merged

feat: Migrate x Modules Search Box to Composition API #1476

merged 23 commits into from
May 23, 2024

Conversation

andreadlgdo
Copy link
Contributor

@andreadlgdo andreadlgdo commented May 16, 2024 •
edited by jira bot

Pull request template

Describe the purpose of the change, the specific changes done in detail, and the issue you have fixed.

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link: EMP-4077

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@andreadlgdo andreadlgdo self-assigned this May 16, 2024
@andreadlgdo andreadlgdo marked this pull request as ready for review May 22, 2024 12:57
@andreadlgdo andreadlgdo requested a review from a team as a code owner May 22, 2024 12:57
@joseacabaneros joseacabaneros merged commit 5c2b7bc into main May 23, 2024
4 checks passed
@joseacabaneros joseacabaneros deleted the feat/EMP-4077-migrate-x-modules-search-box-to-composition-api branch May 23, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseacabaneros joseacabaneros joseacabaneros approved these changes

@diegopf diegopf Awaiting requested review from diegopf

@alvarodE alvarodE Awaiting requested review from alvarodE

@lauramargar lauramargar Awaiting requested review from lauramargar

Assignees

@andreadlgdo andreadlgdo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andreadlgdo @joseacabaneros