Adding Mobile Optimizations for the Educator-facing pages. #4027
Conversation
Update seeds and better error pages.
rollback cors update
Unit Filtering and Better Dropdown CSS
Add donate link for now.
Donate button.
Roll back clever gem
Launch new unit reports.
Polish New Reports
Fix activity reports styling issues
Update styles
Add JWT auth support for Connect
Revert Doorkeeper upgrade.
Update lesson tutorial links
Transfer ownership of classrooms
I changed the copy under Partner Schools and included a link to our financial aid article.
Updating confusing copy about financial aid
Mostly just fixing Clever school importing.
Update demo script.
Deploy Knowledge Center and Subscriptions 2018
Unmerge redux student profile.
Correct case for react
Subscriptions improvements.
Security and un-Jared-ing
Fix string param being compared to integer
Knowledge Center Image uploads
|
Amr Thameen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
…to develop I have worked on a lot of files to add mobile optimization to the educator-facing areas of the site.
|
Here, I added some basic styling when the teacher has not assigned any lessons. Following screenshot showcases the changes. Left side is the local server where I have made changes and the right side is the live site. You can refer to the URLs for authenticity.
|
|
In this commit, I have added mobile optimization for the map page. According to me, the page could have used some amount of width and height changes. Following .gif file showcases the changes. Left side is the local server where I have made changes and the right side is the live site. You can refer to the URLs for authenticity.
|
Codecov Report
@@ Coverage Diff @@
## develop #4027 +/- ##
==========================================
Coverage ? 34.48%
==========================================
Files ? 820
Lines ? 19407
Branches ? 1734
==========================================
Hits ? 6692
Misses ? 12612
Partials ? 103
Continue to review full report at Codecov.
|
|
In this commit, I have added mobile optimization for the /subscriptions page. According to me, there was a need to specify the margins and make sure that everything looks neat and clean. Following .gif file showcases the changes. Left side is the local server where I have made changes and the right side is the live site. You can refer to the URLs for authenticity.
|
|
In this commit, I have added mobile optimization for the /teacher/classroom/new page. The UI was unordered and the padding was not showing up correctly.
|
|
Here, the iframe which was being used was not optimized for mobile view. Also, it had incorrect width and height settings which left a huge area blank on the site. Following .gif file showcases the changes. Left side is the local server where I have made changes and the right side is the live site. You can refer to the URLs for authenticity for the mobile view.
Also, I made changes for the desktop view. Firstly, the live site is shown and then, we can see the local site that I made changes on.
|
|
In this commit, I added some margin so that the pictures look centralized and don't look like they are fixed to the right side of the page. Following .gif file showcases the changes. Left side is the local server where I have made changes and the right side is the live site. You can refer to the URLs for authenticity.
|
|
In this commit, I added a width percentage property which helps in giving a nice scroll effect for the user. Following .gif file showcases the changes. Left side is the local server where I have made changes and the right side is the live site. You can refer to the URLs for authenticity.
|
|
On the /partners page, I saw that the complete iframe was not visible and height changes needed to be made in order to view all the partners. Following .gif file showcases the changes. Left side is the local server where I have made changes and the right side is the live site. You can refer to the URLs for authenticity.
|
|
I saw the error that is taking place and I think it can be dealt with at a later stage. I'll get back to adding optimizations now which are mainly just stylesheets. |
|
In this commit, I saw that alignment was not correct and that margins were not presenting a good UI. Following .gif file showcases the changes. Left side is the local server where I have made changes and the right side is the live site. You can refer to the URLs for authenticity.
|
|
In this commit, I added a mobile friendly UI for the My Account page using CSS Grid. The page was broken and not limiting to the screen width. Following .gif file showcases the changes. Left side is the local server where I have made changes and the right side is the live site. You can refer to the URLs for authenticity.
|
Addresses issue #3871
Changes proposed in this pull request:
Following .gif file showcases the changes. Left side is the local server where I have made changes and the right side is the live site. You can refer to the URLs for authenticity.
Has this branch been QA'd on staging? no
Have you updated the docs? no
Have the tests been updated? no
Reviewer: @ddmck