Factor out try/cartch duplication in nodefs code. NFC #21922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
May 9, 2024
| __wasmfs_node_record_dirent(vec, name, type); | ||
| stackRestore(sp); | ||
| return wasmfsTry(() => { | ||
| let entries = fs.readdirSync(path, { withFileTypes: true }); |
There was a problem hiding this comment.
Should the try be only on this line? It looks like now it includes the lines after as well.
There was a problem hiding this comment.
Its possible, but it would involve complicating the code since it would looks something like this:
let entries_or_error = fwasmfsTry(() => {s.readdirSync(path, { withFileTypes: true });
if (typeof entries_or_error == number) return entries_or_error;
...
There was a problem hiding this comment.
Is that not worth it? In general I think we've preferred such scopes to be as limited as possible, to avoid the risk of unrelated errors being caught.
There was a problem hiding this comment.
The handler here just rethrow stuff that doesn't have a code so it wouldn't be a big issue I think,
There was a problem hiding this comment.
Fair enough, I don't feel strongly.
kripken
approved these changes
May 9, 2024
| __wasmfs_node_record_dirent(vec, name, type); | ||
| stackRestore(sp); | ||
| return wasmfsTry(() => { | ||
| let entries = fs.readdirSync(path, { withFileTypes: true }); |
There was a problem hiding this comment.
Fair enough, I don't feel strongly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.