Test reading from stdin in shell environments #21926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
May 9, 2024
Also refactor FS_stdin_getChar so that it only includes the shell code when needed. I verified that this test runs under spidermonkey and v8.
sbc100
force-pushed
the
test_stdin_under_shell
branch
from
e5a16f8
to
df19a50
Compare
|
Some codesize wins here due to shell code not getting includes anymore by default! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactor FS_stdin_getChar so that it only includes the shell
code when needed.
I verified that this test runs under spidermonkey and v8.