Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRP-13739: Fixed ResizeObserver loop limit exceeded error #319

Merged
merged 6 commits into from Apr 27, 2023

Conversation

stanca-pop-lgp
Copy link
Contributor

@stanca-pop-lgp stanca-pop-lgp commented Apr 24, 2023

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Starting cli 5.1.0 "webpack-dev-server" was updated to latest minor version "^4.9.3". Version 4.12.0 introduced an error that is visible on our console app in agate-apps.
With this version of "webpack-dev-server", at first render or whenever we resize the browser viewport (e.g. by opening developer tools), an error overlay pops up stating "ResizeObserver loop limit exceeded".
This issue is addressed on "webpack-dev-server"'s Github repo: webpack/webpack-dev-server#4771.
The fix for this: webpack/webpack-dev-server#4773. "webpack-dev-server" added this option to show or not runtime errors in an overlay (the default value is true). So if we add runtimeErrors: false in cli we do not get the ResizeObserver loop limit exceeded error any more.

Resolution

Set client.overlay.runtimeErrors to false in serve.js configuration file to avoid showing errors at window resize.

Additional Considerations

Links

WRP-13739

Comments

Enact-DCO-1.0-Signed-off-by: Stanca Pop stanca.pop@lgepartner.com

@daniel-stoian-lgp
Copy link

Please add a changelog entry

CHANGELOG.md Outdated Show resolved Hide resolved
@hong6316
Copy link
Contributor

Could you cut&paste the Resolution description into Issue Resolved / Feature Added?
Then, could you write a summary of what you did in Resolution in brief?

Copy link
Contributor

@hong6316 hong6316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@hong6316 hong6316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hong6316 hong6316 merged commit de6bf65 into develop Apr 27, 2023
2 checks passed
@hong6316 hong6316 deleted the feature/WRP-13739 branch April 27, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants