Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRO-614: Merge feature/webpack5 branch #30

Merged
merged 5 commits into from
Jul 1, 2022

Conversation

MikyungKim
Copy link
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

We need to merge feature/webpack5 branch to feature/storybook-next for updating storybook6.5 and webpack5.
feature/webpack5 branch includes #24, #25 changes.

Resolution

Merge feature/webpack5 branch to feature/storybook-next

Additional Considerations

Links

WRO-614, WRO-378, WRO-343

Comments

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

hong6316 and others added 5 commits March 25, 2022 14:37
* use @babel/eslint-parser

* Revert "use @babel/eslint-parser"

This reverts commit dfc9555.

* babel-eslint -> @babel/eslint-parser

* modify changelog

* Update package.json

Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>

* remove unused package

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* revert shrinkwrap

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
* update eslint 8

* Update package.json

Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>

* Update package.json

Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>

Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
Copy link
Contributor

@hong6316 hong6316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but may need to update modules the latest version later, in feature/storybook-next branch

@hong6316 hong6316 merged commit b818fe1 into feature/storybook-next Jul 1, 2022
@hong6316 hong6316 deleted the feature/webpack5 branch July 1, 2022 00:28
0x64 pushed a commit that referenced this pull request Sep 16, 2022
* WRO-614: Merge `feature/webpack5` branch (#30)

* WRN-12124: Remove deprecated babel-eslint module (#24)

* use @babel/eslint-parser

* Revert "use @babel/eslint-parser"

This reverts commit dfc9555.

* babel-eslint -> @babel/eslint-parser

* modify changelog

* Update package.json

Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>

* remove unused package

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* revert shrinkwrap

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>

* WRN-12748: Update eslint 8 related modules in tool repos (#25)

* update eslint 8

* Update package.json

Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>

* Update package.json

Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>

Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>

* added a changelog

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* typo

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

Co-authored-by: taeyoung.hong <35059065+hong6316@users.noreply.github.com>

* WRO-614: Migrate to storybook 6.5 and webpack5 (#31)

* initial commit

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* Migrate to webpack5

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* update dependencies and changelog

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* fix travis fail

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* removed unnecessary change

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* update dependencies

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* WRO-7575: Fix ContextualPopup is not showing properly with webpack5 (#32)

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

Co-authored-by: taeyoung.hong <35059065+hong6316@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants