Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Check urlpatterns after cleanups #9400

Merged
merged 1 commit into from
May 7, 2024

Commits on May 6, 2024

  1. tests: Check urlpatterns after cleanups

    According to docs:
    https://docs.python.org/3/library/unittest.html#unittest.TestCase.addClassCleanup
    
    > Add a function to be called after tearDownClass() to cleanup resources
      used during the test class. Functions will be called in reverse order to
      the order they are added (LIFO).
    
    This was revealed with recent change in pytest (`8.2.0`):
    > pytest-dev/pytest#11728: For unittest-based tests, exceptions during
      class cleanup (as raised by functions registered with
      TestCase.addClassCleanup) are now reported instead of silently failing.
    
    `check_urlpatterns` is called before `cleanup_url_patterns` and fails
    (problem was hidden by `pytest < 8.2.0`).
    
    `doClassCleanups` can be used instead to check after-cleanup state:
    
    https://docs.python.org/3/library/unittest.html#unittest.TestCase.doClassCleanups
    
    > This method is called unconditionally after tearDownClass(), or after
      setUpClass() if setUpClass() raises an exception.
    
      It is responsible for calling all the cleanup functions added by
      addClassCleanup(). If you need cleanup functions to be called prior to
      tearDownClass() then you can call doClassCleanups() yourself.
    
    Fixes: encode#9399
    Signed-off-by: Stanislav Levin <slev@altlinux.org>
    stanislavlevin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    b96af1f View commit details
    Browse the repository at this point in the history