Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type of Extensions #762

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

karpetrosyan
Copy link
Member

@karpetrosyan karpetrosyan commented Jul 28, 2023

Closes #761

Checklist

  • Change type of the extensions.
  • Update changelog

@karpetrosyan karpetrosyan requested a review from a team July 28, 2023 11:41
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
@karpetrosyan
Copy link
Member Author

Thank you @Kludex !

@karpetrosyan karpetrosyan merged commit c86d507 into encode:master Jul 28, 2023
5 checks passed
This was referenced Aug 1, 2023
@tomchristie
Copy link
Member

Just coming back to this ...and... any reason for use to not use Dict[...] here instead?
Would that be preferable?

@karpetrosyan
Copy link
Member Author

It makes no difference for httpx; for httpcore, it's just a bit of reusability.

Other libraries built on top of httpcore can use more than just a dictionary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the type of extension from Mapping to MutableMapping.
4 participants