Pre encoded path/params/fragments should be kept

[elupus]

Summary

URL with pre-encoded segments would end up double encoded when parsed by the URL parser. We must consider the % as a safe value, to avoid encoding it here.

Related to comments in #2883
Related #2723
Duplicate #2929

Checklist

• I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
• I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
• I've updated the documentation accordingly.

[zanieb]

This makes sense to me. I stumbled upon this behavior in the / encoding implementation and was confused.

[T-256]

I don't think this PR fixes #2883. That was about encodes forward slash.
Does this comment need to be updated accordingly?
Is this behavior change?

[elupus]

I don't think this PR fixes #2883. That was about encodes forward slash. Does this comment need to be updated accordingly? Is this behavior change?

Hmm. Well not the initial report there indeed. But the the receiver of that url should url decode. Not doing that would be a bug in its parser.

It might only fix the followup comments with similar issues.

[ttys0dev]

I don't think this will work, it's still corrupting the parameter by encoding / to %2F which is something not all servers can handle.

[elupus]

Moving to draft n favor off #2980

[zanieb]

While I think we may want to revert the behavior that encodes /, I think this change doesn't need to be conflated with that. We should not double-encode already encoded characters — that's a clear bug from my perspective. I'd rather review the changes in isolation so we can have a discussion about one thing at a time. Perhaps the approach taken in #2980 is better but I'm not sure you should include the / encode revert there.

[tomchristie]

Thanks for taking a look at this @elupus, I've been planning to address this for a while and have taken a fresh pass on it at #2990. Reviews appreciated.

(Also, I like your approach artist fka @madkinsz - yep separating out the different aspects is almost always the tack I prefer.)

[tomchristie]

Superseeded by #2990