Add options to support SPAs in StaticFiles #2591
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two changes, the first is to support loading files from packages that might not be present at instantiation and are built asynchronously from webpack or the like. This is already supported for the directory option but it works with packages as well. The second is the fallback_file option which is used in client side routing. These tools expect that any path that doesn't resolve to a file in the build directory will return the main SPA file (typically index.html).
|
I think we tried to introduce the "fallback_file" with a different name some time ago... 🤔 I prefer the changes to be atomic, yes. And I think there's a discussion, or PR about your first point - you might want to check that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are two changes supporting one aim, if you don't consider that to be atomic I can open two PRs.
fallback_fileoption which is used in client side routing. These tools expect that any path that doesn't resolve to a file in the build directory will return the main SPA file (typicallyindex.html).Checklist
Fixes #1821
An example of someone in the wild wanting this kind of functionality: https://stackoverflow.com/questions/63069190. I think the examples you find around the web to be insufficient in the case where
index.htmlis part of your static bundle that might live in a package.