Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reason support on WebSocketDisconnectEvent #2324

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

frankie567
Copy link
Member

Summary

In the ASGI specification repo, we recently talked about the lack of support for the reason field in the WebSocketDisconnectEvent. This will be likely added to the spec soon.

This PR adds support for this new addition. It doesn't need to be merged before the spec is officially modified, but we're already prepared here 馃槃

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly. Don't think it's necessary for this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants