Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[grafana] add grafana 11 #5129

Merged
merged 2 commits into from
May 15, 2024
Merged

[grafana] add grafana 11 #5129

merged 2 commits into from
May 15, 2024

Conversation

ajayk
Copy link
Contributor

@ajayk ajayk commented May 14, 2024

@captn3m0
Copy link
Member

could you undo the indentation changes or file a new PR without those?

@ajayk
Copy link
Contributor Author

ajayk commented May 15, 2024

could you undo the indentation changes or file a new PR without those?

addressed in the same PR , PTAL

BiNZGi
BiNZGi requested changes May 15, 2024
View reviewed changes
Copy link
Member

@BiNZGi BiNZGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update 10.3 and 9.5 eol to 2024-05-14

@BiNZGi BiNZGi mentioned this pull request May 15, 2024
Merged
@ajayk ajayk requested a review from BiNZGi May 15, 2024 16:14
BiNZGi
BiNZGi requested changes May 15, 2024
View reviewed changes
Copy link
Member

@BiNZGi BiNZGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking the preview I noticed that we missed to update the eol of 8. Please update it to the releaseDate of 10.0 -> 2023-06-09
Rest is okay now 👍

@ajayk ajayk requested a review from BiNZGi May 15, 2024 19:28
BiNZGi
BiNZGi approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@BiNZGi BiNZGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, all good now -> merge

@BiNZGi BiNZGi merged commit 229ef9b into endoflife-date:master May 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BiNZGi BiNZGi BiNZGi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajayk @captn3m0 @BiNZGi