test(marshal,exo): stop exporting from test-*.js files #2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-tests-dont-export
branch
from
91ee662
to
4a2c960
Compare
erights
force-pushed
the
markm-tests-dont-export
branch
from
4a2c960
to
a4b7609
Compare
dckc
approved these changes
Feb 12, 2024
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
refs: #XXXX
Description
At #2008 (comment) @dckc explained why
test/test-*.jsfiles should not export things. Currently, we have a few of those. This PR reforms those, moving shared stuff into separatetest/*.jsfiles that are nottest-*files, and exporting from there.Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
The whole point. By exporting from one
test-*.jsfile and importing into another, ava would run sometimes run the exporting test twice, or when it did not need to.Compatibility Considerations
none
Upgrade Considerations
none
Nothing breaking.
No news updates warranted.
*BREAKING*:in the commit message with migration instructions for any breaking change.NEWS.mdfor user-facing changes.