Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update modules graph evaluation algorithms #211

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update modules graph evaluation algorithms #211

wants to merge 5 commits into from

Conversation

nicolo-ribaudo
Copy link
Contributor

  • Some fields have been renamed in ECMA-262
  • The logic to track ancestors in AsyncModuleExecutionFulfilled has been updated to properly transition every module in cycles

This fixes a bug where the [[Status]] of some modules in cycles with TLA wasn't properly updated from evaluating-async to evaluated, even if it's not observable in user code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicolo-ribaudo @Jack-Works