Update setting-the-length-of-an-array.md #2535
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog
|
kapnobatai137
suggested changes
Jan 7, 2021
javascript/javascript-core/javascript-arrays/setting-the-length-of-an-array.md
Outdated
Show resolved
Hide resolved
javascript/javascript-core/javascript-arrays/setting-the-length-of-an-array.md
Outdated
Show resolved
Hide resolved
javascript/javascript-core/javascript-arrays/setting-the-length-of-an-array.md
Outdated
Show resolved
Hide resolved
javascript/javascript-core/javascript-arrays/setting-the-length-of-an-array.md
Outdated
Show resolved
Hide resolved
javascript/javascript-core/javascript-arrays/setting-the-length-of-an-array.md
Outdated
Show resolved
Hide resolved
sourabhv
reviewed
Jan 7, 2021
| @@ -5,6 +5,8 @@ category: hack | |||
| tags: | |||
| - introduction | |||
| - obscura | |||
| links: | |||
| - '[Array holes](https://medium.com/better-programming/what-are-holes-in-arrays-3ac5fcbcd1c){website}' | |||
There was a problem hiding this comment.
cc @nem035 if there's a better link for this
| - size | ||
| - `[1,2,undefined,undefined,undefined]` | ||
| - `[1,2,<3 empty items>]` |
There was a problem hiding this comment.
Maybe leave this one as undefined
Suggested change
| - `[1,2,<3 empty items>]` | |
| - `[1, 2, undefined, undefined]` | |
| - `[1, 2, <1 empty item>, <1 empty item>]` |
There was a problem hiding this comment.
[Undefined, undefined] or [<1empty sitem> , <1 empty item>]
There was a problem hiding this comment.
Aha, nvm I think I got it. The first correct answer should be:
[1, 2, <1 empty item>, <1 empty item>]
and the incorrect one should be
[1, 2, undefined, undefined]
right? @sourabhv
…h-of-an-array.md Co-authored-by: Andrei Calabangiu <andrei@enki.com>
…h-of-an-array.md Co-authored-by: Andrei Calabangiu <andrei@enki.com>
…h-of-an-array.md Co-authored-by: Andrei Calabangiu <andrei@enki.com>
…h-of-an-array.md Co-authored-by: Andrei Calabangiu <andrei@enki.com>
…h-of-an-array.md Co-authored-by: Andrei Calabangiu <andrei@enki.com>
…h-of-an-array-javascript-core-arrays
|
@Stefan-Stojanovic what's left to do for this PR? |
I wasn't sure what to change based on sourabhs comment and was waiting on the reply |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.