Add Custom Highlight Support for AutoComplete #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See changes in readme for detail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was trying out the AutoComplete prompt I found the highlighting bug. I saw the pr that has fixed the bug but it's just disabling the feature when the highlighting function can't work properly. Also the package on npm doesn't seem to have patched it yet. So I went a step further to add custom highlighting support.
The way I implement it involves adding a new property to the choice objects. I'm not sure if it's a good idea. And I just realized maybe I could achieve the same result without modifying autocomplete.js, by managing choice objects in suggest function. But it's working code and it doesn't seem to affect existing code, so I decided to create this pr.
I also added description and sample code for this feature to readme. Please check it out for details.