fix: update type definitions #261
Open
+11,089
−351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converted some support functions to TypeScript
input, confirm, numberal, password, invisible, toggle, basicauth
So that they can be used when declaring custom types
or else cannot support mix Question + Fn. also restored original typescript test
The skipped test could be a bug, but without a clean way to test the code, it is more problematic to fix it then not.
|
Hi @unional – thanks for this PR! I'm noticing a lot of inaccuracies in the current type definitions (I'm having to use Are you still working on this? How can I help get this merged? |
Thanks @bitjson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the new type definition.
I have moved the test files to a different folder and keep the existing JS tests
The
promptfunction support discriminated unions. It means depending on thetype, you will get different code completion.The actual
Promptand their sub-classes have their own types and separate from those used in thepromptfunction because I'm not very clear on what property, method, and options these classes should expose for customization and for creating custom prompts. So separating them allow them to be evolved and expend separately.Let me know what do you think. 🍺