Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wheel menu items should highlight when hovered #9904

Closed
AdRiley opened this issue May 9, 2024 · 1 comment · Fixed by #10002
Closed

Wheel menu items should highlight when hovered #9904

AdRiley opened this issue May 9, 2024 · 1 comment · Fixed by #10002
Assignees
@farmaazon
Labels
-gui d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint x-new-feature Type: new feature request
Milestone
Beta Release

Comments

@AdRiley
Copy link
Member

AdRiley commented May 9, 2024 •
edited by farmaazon

When hovering the wheel menu items their

  • background should highlight (like the add new component button does)
  • icon should darken

Also, the icons in circular menu should have the same color as visualization buttons, including plus icon for adding nodes.
@AdRiley AdRiley added x-new-feature Type: new feature request -gui labels May 9, 2024
@AdRiley AdRiley added this to the Beta Release milestone May 9, 2024
@farmaazon farmaazon added d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints labels May 9, 2024
@farmaazon
Copy link
Contributor

  • Optional: make circular menu animated.

@farmaazon farmaazon mentioned this issue May 9, 2024
Closed
@farmaazon farmaazon added p-high Should be completed in the next sprint and removed p-medium Should be completed in the next few sprints labels May 9, 2024
@farmaazon farmaazon self-assigned this May 17, 2024
@enso-bot enso-bot bot mentioned this issue May 17, 2024
Closed
@farmaazon farmaazon mentioned this issue May 20, 2024
Merged
3 tasks
@mergify mergify bot closed this as completed in #10002 May 20, 2024
mergify bot pushed a commit that referenced this issue May 20, 2024
@farmaazon
Icon highlight and SvgButton (#10002)
65f28c3 
Fixes #9904

Refactored our button: the common logic of "button being an SVG icon" moved to new `SvgButton` component. Simplified and unified CSS. Added hover highlight.

![image](https://github.com/enso-org/enso/assets/3919101/40aa628c-4181-487c-a0f7-b49e06d274b8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@farmaazon farmaazon

Labels
-gui d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint x-new-feature Type: new feature request
Projects
Issues Board
Status: 🟢 Accepted
Milestone
Beta Release
Development

Successfully merging a pull request may close this issue.

Icon highlight and SvgButton enso-org/enso
2 participants
@AdRiley @farmaazon