Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloud endpoints for frontend #6002

Merged
merged 206 commits into from
Apr 6, 2023

Conversation

somebody1234
Copy link
Collaborator

@somebody1234 somebody1234 commented Mar 20, 2023

Pull Request Description

Adds functions and types to access backend endpoints.
This is in preparation for upcoming PRs that will flesh out the dashboard UI.

Important Notes

Has not been tested since it is not currently used. It will be used (and tested) in future PRs.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@sylwiabr
Copy link
Member

@somebody1234 is it ready for merge?

@somebody1234
Copy link
Collaborator Author

no, #6034 and #6132 need to be QA'd + merged first, then this and #6004 need to be QA'd too

@somebody1234 somebody1234 mentioned this pull request Mar 30, 2023
5 tasks
@PabloBuchu
Copy link
Contributor

@somebody1234 can you update it with latest develop (of course by updating PRs in the chain). Can't build it on macos

@somebody1234 somebody1234 changed the base branch from wip/somebody1234/cognito-auth-prettier to wip/somebody1234/esbuild-for-dashboard March 30, 2023 12:17
@somebody1234 somebody1234 marked this pull request as draft March 31, 2023 07:53
Base automatically changed from wip/somebody1234/esbuild-for-dashboard to develop March 31, 2023 14:19
@somebody1234 somebody1234 marked this pull request as ready for review March 31, 2023 14:26
@somebody1234 somebody1234 force-pushed the wip/somebody1234/cloud-endpoints-for-frontend branch from 7362395 to 7fcbf21 Compare March 31, 2023 14:34
@somebody1234
Copy link
Collaborator Author

(also force-pushing only the last merge commit)

@wdanilo
Copy link
Member

wdanilo commented Apr 4, 2023

  1. How the Q/A was made @indiv0 if watch is broken?
  2. If this PR could not be merged, it should be in draft state.
  3. Doing Q/A of a PR waiting for other PRs to be merged does not make a lot of sense, as the Q/A would need to be done again when this PR will be ready to merge.

@PabloBuchu
Copy link
Contributor

I will merge this. Build and authentication works. Fix for broken watch is on the separate PR #6212

@PabloBuchu PabloBuchu added the CI: Ready to merge This PR is eligible for automatic merge label Apr 6, 2023
@mergify mergify bot merged commit 6a09f12 into develop Apr 6, 2023
23 checks passed
@mergify mergify bot deleted the wip/somebody1234/cloud-endpoints-for-frontend branch April 6, 2023 10:00
Procrat added a commit that referenced this pull request Apr 6, 2023
* develop:
  Project Sharing (#6077)
  Adjust `{Table|Column}.parse` to use `Value_Type` (#6213)
  Add cloud endpoints for frontend (#6002)
  Implement `Table.union` for Database backend (#6204)
  Batch insert suggestions (#6189)
  Formatter fix to not fail when encountering an invalid symlink. (#6172)
  Suspended atom fields are evaluated only once (#6151)
  Text.to_display_text is (shortened) identity (#6174)
  Engine benchmark visualization tool can compare two bench runs (#6198)
  Add PRIVATE so function hidden from Component Browser and other tidying... (#6207)
  Hotfix for #6203. (#6210)
@indiv0
Copy link
Contributor

indiv0 commented Apr 11, 2023

  1. How the Q/A was made @indiv0 if watch is broken?

Apologies, I only tested that watch builds and opens the IDE and that the flow works successfully. I did not try to make changes to the source.

MichaelMauderer pushed a commit that referenced this pull request Apr 25, 2023
Adds functions and types to access backend endpoints.
This is in preparation for upcoming PRs that will flesh out the dashboard UI.

# Important Notes
Has not been tested since it is not currently used. It will be used (and tested) in future PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants